[Bug 757657] Review Request: perl-Wx-Scintilla - Scintilla source code editing component for wxWidgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=757657



--- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> ---
I compared Wx-Scintilla-0.39 with scintilla-3.0.4 and there are very small
differences:

(1) scintilla's lexers, lexlib and src directories content is merged into
Wc-Scintilla's src directory.

(2) Wx-Scintilla's "include" directory is missing Face.py and HFacer.py files.
These are used only for generating headers from Scintilla.iface file.

(3) Wx-Scintilla's "include" directory extends SciLexer.h because Wx-Scintilla
adds support for Perl6 lexer.

--- /tmp/scintilla-3.0.4/include/SciLexer.h     2012-03-08 03:59:38.000000000
+0100
+++ include/SciLexer.h  2012-09-04 12:20:47.000000000 +0200
@@ -118,6 +118,7 @@
 #define SCLEX_TCMD 103
 #define SCLEX_AVS 104
 #define SCLEX_ECL 105
+#define SCLEX_PERL6 199
 #define SCLEX_AUTOMATIC 1000
 #define SCE_P_DEFAULT 0
 #define SCE_P_COMMENTLINE 1
@@ -359,6 +360,9 @@
 #define SCE_PL_STRING_QQ_VAR 64
 #define SCE_PL_STRING_QX_VAR 65
 #define SCE_PL_STRING_QR_VAR 66
+#define SCE_P6_DEFAULT  0
+#define SCE_P6_COMMENT  1
+#define SCE_P6_STRING   2
 #define SCE_RB_DEFAULT 0
 #define SCE_RB_ERROR 1
 #define SCE_RB_COMMENTLINE 2

(4) Wx-Scintilla's "lexers" directory adds LexPerl6.cxx file with the Perl6
lexer. It does not bring any new dependencies or incompatibilities.

(5) Wx-Scintilla patches PropSetSimple.cxx and WordList.cxx in liblex directory
because of Visual C++ compiler. It also patches SparseState.h for unknown
reason:

--- /tmp/scintilla-3.0.4/lexlib/SparseState.h   2011-09-16 11:13:20.000000000
+0
200
+++ lexlib/SparseState.h        2012-09-04 12:20:47.000000000 +0200
@@ -92,7 +92,7 @@
                                changed = true;
                        }
                        typename stateVector::const_iterator startOther =
other.
states.begin();
-                       if (!states.empty() && !other.states.empty() &&
states.b
ack().value == startOther->value)
+                       if (!states.empty() && states.back().value ==
startOther
->value)
                                ++startOther;
                        if (startOther != other.states.end()) {
                                states.insert(states.end(), startOther,
other.st
ates.end());

(6) Wx-Scintilla removed LexGen.py and SciTE.properties from "src" directory.
The SciTE.properties is for SciTE editor which is now a standalone project and
the LexGen.py regenerates sources.

These are the only differences.

Other question is if it possible to build scintilla without an implicit binding
to GTK as is done in the upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]