https://bugzilla.redhat.com/show_bug.cgi?id=1245604 --- Comment #4 from Nikola Forró <nforro@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > License file is not installed. Add %license LICENSE > [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]. > There is no license file in the tarball. It was added to upstream master branch later, so it will probably be included in the next release. > %post/%postun scriplets should be suffixed with || : so that they cannot > fail. > Fixed. > I'm not a vim expert, but comparing the scriptlets with vim-taglist I see > that vim-taglist removes the file, but you truncate it... Is this > intentional? > With rm, rpmlint complains about dangerous command in %postun section. > I don't think use should mark %{vimfiles_root}/doc/* with %doc. Packages are > not allowed to use stuff marked with %doc at runtime, but this help is used > by vim itself, no? > That's right, fixed. > Who owns %{vimfiles_root}/autoload, %{vimfiles_root}/compiler, > %{vimfiles_root}/ftdetect, etc? Most likely your package should (co-)own > those directories. Those directories are owned by vim-filesystem package, which is "artificial filesystem" package and it also exists in vim-go's dependency chain, so vim-go shouldn't co-own them. Updated files: Spec URL: https://nforro.fedorapeople.org/vim-go.spec SRPM URL: https://nforro.fedorapeople.org/vim-go-1.0.5-4.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review