https://bugzilla.redhat.com/show_bug.cgi?id=1241919 --- Comment #27 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- Looking good -- several observations: - you don't need to define python2_sitelib, since this is an arch-dependent package and you're installing the files to python2_sitearch - in fact, if you're only targeting newer Fedora releases you can assume python2_sitearch is defined anyway (rpmdev-newspec -t python doesn't define it anymore) - no need to ghost %{_bindir}/kernprof if it's never going to be created - there are some test files available in tests/ ; you should run them in a %check section: %check pushd %{pkgname}-%{version} %{__python2} -m unittest discover -s tests -v popd %if 0%{?with_python3} pushd python3 %{__python3} -m unittest discover -s tests -v popd %endif (by convention the %check section is placed after the %install section) - use the unittest module in discovery mode - start looking for tests in the tests directory - verbose output (one line per test) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review