https://bugzilla.redhat.com/show_bug.cgi?id=1219612 --- Comment #5 from Troy Dawson <tdawson@xxxxxxxxxx> --- (In reply to Parag AN(पराग) from comment #3) > Review: > > + Package build successfully in mock F24 x86_64 > > + rpmlint on all generated rpms gave output > nodejs-mongodb-core.noarch: W: only-non-binary-in-usr-lib > 2 packages and 0 specfiles checked; 0 errors, 1 warnings. > > + Packaged source verified with upstream as (sha256sum) > source in > tarball:6efaf61e6ceaa1fc322a01c480fcf347a1c8e57d911dc6546d4e87b5922d41b5 > source from upstream: > 6efaf61e6ceaa1fc322a01c480fcf347a1c8e57d911dc6546d4e87b5922d41b5 > > + License "ASL 2.0" is valid and is included in LICENSE file. > > + follow nodejs packaging guidelines > > Suggestions: > 1) Group tag is not necessary except you have plans to build this for EPEL5. > > 2) you should follow > https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/ > Packagers#ExclusiveArch and use > > ExclusiveArch: %{nodejs_arches} noarch > > 3) also we have a license tag to mark license files so you should use > %license LICENSE > > See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > > APPROVED. Thank you for the review. I like all of your suggestions, and will implement them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review