[Bug 1244764] Review Request: rubygem-diffy - Convenient diffing in ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1244764



--- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Thanks for the update.

* Better description
  - I forgot to mention that the description is not really descriptive :/ Could
    you please update the description? Probably the first paragraph from
    README.md will do the job.

* Dependency on diff
  - Since I read the description now ( ;) ), I noticed that that the package
    depends on external diff. It might be good idea to include
    "Recommends: %{_bindir}/diff". On the other hand, I am not 100% sure if
that
    is really needed because:

    1) diff is very likely available even in some minimal installation
    2) The case when diff is not available looks to be handled gracefully
       (although the message is probably not very clear).
    3) There could be used also rubygem-diff-lcs alternatively (but this is not
       very likely due to (1))

    So I leave it up to you, I just wanted to mention it here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]