https://bugzilla.redhat.com/show_bug.cgi?id=1244764 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #1 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Hi Ilya, Looking on the .spec file, I see a few small issues: * Test suite is not executed. - It is good habit to execute the test suite, since it is the only way how to be sure that the code actually works. There is no compiler or anything else which would watch your back. You can refer to Ruby packaging guidelines [1] how to do this. * You should not ship hidden files in you package. - There are excluded several dot files, but you missed the "%{gem_instdir}/.rspec" - In my packages, I usually remove all of them by simple: "%{gem_instdir}/.*" - This issue is reported by rpmlint, so I guess you did not run it. This is suggested by packaging guidelines [2] as well as review guidelines [3]. I can sponsor you, but I would appreciate, if you can take a look on some other packages and submit informal reviews to take more familiar with Fedora packaging process and guidelines. I am pretty sure you can find some other GitLab related packages already submitted for a review in Bugzilla. BTW you lists two FAS nicks and the changelog states that the .spec file was prepared by Igor Gnatenko, so could you please clarify who is actually author and submitter etc. Just to be clear. Thank you. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Testing_frameworks_usage [2] https://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint [3] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines [4] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review