[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1243507

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Petr Šabata <psabata@xxxxxxxxxx> ---
(In reply to Bill Pemberton from comment #4)
> I just realized that I removed perl from the BuildRequires instead of just
> removing the version requirement.  Do I need to add that back or is it ok to
> assume the other perl BuildRequires will take care of it?

Add it back.  Although it's almost certain something will pull perl into the
buildroot, you can never know.  And since you're using it yourself, you need to
buildrequire it.

Anyhow, I trust you'll add it before pushing the package.  I ack you've fixed
everything I've pointed out so I'm going to approve this now :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]