https://bugzilla.redhat.com/show_bug.cgi?id=1235305 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #14 from Christopher Meng <i@xxxxxxxx> --- I have some advices for the spec: 1. %if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units BuildRequires: systemd-units %else You should use 'systemd' instead of 'systemd-units' for these 4 entries. 2. BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) This line is not needed if you don't plan to push it to el5(I think so). 3. LDFLAGS="%{optflags} -pie" There must be something wrong within your project, I don't think cflags should be inserted here, should be %{__global_ldflags} instead. 4. rm -rf %{buildroot} Drop it unless for el5. 5. # check is not enabled by default, as it won't work on the koji builders, # nor on machines that can't reach the Internet. %check %if 0%{?runcheck} == 1 cd tests; ./runtests cd - %endif Maybe 'cd -' is redundant? 6. Drop %clean section unless for el5. 7. Drop %defattr(-,root,root,-) 8. Consider %ghost %verify(not md5 size mtime) /run/hitch/hitch.pid at %files. 9. hitch is a network proxy that terminates TLS/SSL connections and forwards the unencrypted traffic to some backend. It is designed to handle 10s of thousands of connections efficiently on multicore machines A missing dot at the end of the final line. 10. %{_mandir}/man8/hitch.8.gz -> %{_mandir}/man8/hitch.8* This will help once they are not compressed(RPM will compress these pages). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review