https://bugzilla.redhat.com/show_bug.cgi?id=1244102 Marcin Haba <marcin.haba@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marcin.haba@xxxxxxxxx --- Comment #3 from Marcin Haba <marcin.haba@xxxxxxxxx> --- Hello, I am not Fedora packages maintainer, so my review is informal. I have five following points about your Spec and package: 1) Source0 should be URL available to download, not %{name}-%{version}-%{gh_short}.tgz https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Referencing_Source 2) "URL" value is not possible to open from Spec file due to macros used. I am not sure if here are allowed macros. "URL: The full URL for more information about the program" from: https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview I would ask somebody else for confirm or nagate this point. 3) The %clean section is not required for F-13 and above. https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean 4) In Spec comment: # git snashop to get upstream test suite What is it snashop? Do you mean snapshot? 5) rpmlint shows on RPM: php-composer-spdx-licenses.noarch: E: script-without-shebang /usr/share/php/Composer/Spdx/autoload.php php-composer-spdx-licenses.noarch: E: script-without-shebang /usr/share/php/Composer/Spdx/SpdxLicenses.php The two scripts have executable permissions. When you unset executable permission on these files then should be OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review