https://bugzilla.redhat.com/show_bug.cgi?id=1203018 --- Comment #23 from Marcin Haba <marcin.haba@xxxxxxxxx> --- Spec URL: http://bacula.pl/downloads/baculum/baculum.spec SRPM URL: http://bacula.pl/downloads/baculum/baculum-7.0.6-0.5.b.fc22.src.rpm Changes: - Change baculum.users and Data/ directory permissions to more restrictive - Add noreplace param to Lighttpd config file - Add systemd macros for httpd subpackage - Fix systemd action in post section - Move DESTDIR target and languages to global variables - Do not remove settings file when a web server specific package is removed (used move action) - Drop storing Lighttpd logs in separate logs directory - Define locale files Hello, I have next spec and srpm update. I hope that this update is last one before review process. Almost every day I get to know something new from Packaging Guidlines and from time to time I am seeing something to change, fix or improve in my Spec file. >From this reason also every comment or notice is important for me. I used rpmlint on packages. I attached results below. For now I would solve this error: baculum-httpd.noarch: E: non-readable /usr/share/baculum/htdocs/protected/Data/baculum.users 0600L In this "baculum.users" file are stored HTTP Basic auth credentials. From this reason privilages are 0600. I think that I cannot move the file to /etc because the file is modifying via Baculum web interface and it might be strange that web application make modification in /etc file. And of course it is danterous. $ rpmlint ./baculum.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ./baculum-7.0.6-0.5.b.fc22.noarch.rpm baculum.noarch: W: spelling-error %description -l en_US bconsole -> console, b console, consolable baculum.noarch: W: dangerous-command-in-%post ln baculum.noarch: W: dangerous-command-in-%preun rm 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint ./baculum-selinux-7.0.6-0.5.b.fc22.noarch.rpm baculum-selinux.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ./baculum-httpd-7.0.6-0.5.b.fc22.noarch.rpm baculum-httpd.noarch: W: no-documentation baculum-httpd.noarch: E: non-readable /usr/share/baculum/htdocs/protected/Data/baculum.users 0600L baculum-httpd.noarch: W: dangerous-command-in-%preun mv 1 packages and 0 specfiles checked; 1 errors, 2 warnings. $ rpmlint ./baculum-lighttpd-7.0.6-0.5.b.fc22.noarch.rpm baculum-lighttpd.noarch: W: no-documentation baculum-lighttpd.noarch: W: non-standard-uid /usr/share/baculum/htdocs/protected/Data lighttpd baculum-lighttpd.noarch: W: non-standard-gid /usr/share/baculum/htdocs/protected/Data lighttpd baculum-lighttpd.noarch: W: non-standard-uid /usr/share/baculum/htdocs/protected/Data/baculum.users lighttpd baculum-lighttpd.noarch: W: non-standard-gid /usr/share/baculum/htdocs/protected/Data/baculum.users lighttpd baculum-lighttpd.noarch: E: non-readable /usr/share/baculum/htdocs/protected/Data/baculum.users 0600L baculum-lighttpd.noarch: W: non-standard-uid /var/cache/baculum lighttpd baculum-lighttpd.noarch: W: non-standard-gid /var/cache/baculum lighttpd baculum-lighttpd.noarch: W: dangerous-command-in-%preun mv 1 packages and 0 specfiles checked; 1 errors, 8 warnings. $ rpmlint ./baculum-7.0.6-0.5.b.fc22.src.rpm baculum.src: W: spelling-error %description -l en_US bconsole -> console, b console, consolable 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review