[Bug 1241423] Review Request: nodejs-esprima-fb - Facebook-specific fork of the esprima project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241423

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review-



--- Comment #3 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
There are some issues with Python:

fedora-review gives
- Package contains BR: python2-devel or python3-devel

rpmlint:
sh: /usr/bin/python: No such file or directory

I expect this be caused by tools/generate-unicode-regex.py. To fix the issues
you would have to add python as requires+BR or remove the file in %prep if it
is not needed.


The test/3rdparty directory has two issues:
1. these are probably "bundled libraries" and need to be unbundled
2. there are two files with other licenses. XMLHttpRequest.js and
mootools-1.4.1.js

I think best way handle this would be to remove that directory as tests are
disabled anyway.


the rest of the package looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]