[Bug 1228865] Review Request: gdouros-anaktoria-fonts - A font based on "Grecs du roi" and the "First Folio Edition of Shakespeare"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1228865



--- Comment #8 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> > > %description seems to contain a private use unicode character (1480󿀄
> > > 1561).
> > 
> > Thanks, there was a funny-looking zero, I fixed it in both the spec file and
> > the metainfo.xml file. By the way, which tool picked that up?
> I does not display properly in firefox on my system, and I started
> investigating.
> You probably have the right font installed.

I usually edit files in bluefish, vi or gedit and their monospace fonts
displayed a regular zero. When I transferred the description text to
libreoffice writer I was able to see what was wrong.

> Most likely you have /etc/mock/default.cfg linked to fedora-21-x86_64.cfg.
> I link it to fedora-rawhide-x86_64.cfg instead.

Actually it was linked to fedora-20-x86_64.cfg. Strange.

> To sum up, please add:
> - a comment about the license
> - %check with appstream-util validate-relax

I have updated the spec file with a license-like comment, "BuildRequires: 
libappstream-glib" and the appstream validation check. I should probably amend
my other gdouros-*-fonts packages as well.

> Package is APPROVED.

Great, thanks! So can I set the cvs flag now? 

> Are all Douros fonts packaged? If you have any left to package, I'll be
> happy to review.

That would be really nice of you. I have Aroania and Asea in the review queue
(and I've just updated their spec files according to your remarks) which
together with Anaktoria and Alexander comprise upstream's TextFonts package:
https://bugzilla.redhat.com/show_bug.cgi?id=1228868
https://bugzilla.redhat.com/show_bug.cgi?id=1228869

There are a few more of his fonts that have never been packaged, I hope the
internet archive keeps a copy of all of them, just in case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]