https://bugzilla.redhat.com/show_bug.cgi?id=1241614 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Petr Šabata from comment #3) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > That CPAN metadata you're referring to was added for version 1.10, released > yesterday. Version 1.09 (this review) only mentions license information in > the source (GPLv3+ for the module and GPLv2+ for the reflow script). > > However, I've updated the package and changed the main package License tag > to "GPLv3+ and (GPL+ or Artistic)". The perl part of the module is still > GPLv3+ only. > > And the reflow script still uses GPLv2+. Pff, what a mess. Please add a comment explaining the licensing breakdown to the spec file [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios]. > * Version bumped to 1.10 > * License tag updated > * Build time dep list updated > * Patch dropped as it was incorporated upstream > * Module files are listed only once OK, fedora-review doesn't see any issues. Requires and Depends look correct. Package is APPROVED. Rpmlint ------- Checking: perl-Text-Reflow-1.10-1.fc23.x86_64.rpm reflow-1.10-1.fc23.noarch.rpm perl-Text-Reflow-1.10-1.fc23.src.rpm perl-Text-Reflow.x86_64: W: spelling-error Summary(en_US) reflowing -> re flowing, re-flowing, ref lowing perl-Text-Reflow.x86_64: W: spelling-error %description -l en_US filehandle -> file handle, file-handle, mishandle reflow.noarch: W: no-documentation reflow.noarch: E: incorrect-fsf-address /usr/bin/reflow reflow.noarch: W: no-manual-page-for-binary reflow perl-Text-Reflow.src: W: spelling-error Summary(en_US) reflowing -> re flowing, re-flowing, ref lowing perl-Text-Reflow.src: W: spelling-error %description -l en_US filehandle -> file handle, file-handle, mishandle 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory reflow.noarch: W: no-documentation reflow.noarch: E: incorrect-fsf-address /usr/bin/reflow reflow.noarch: W: no-manual-page-for-binary reflow 3 packages and 0 specfiles checked; 1 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review