[Bug 1244196] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1244196

Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevin@xxxxxxxxxxxxxxxx



--- Comment #2 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> ---
* The non-echoing of build commands is a clear review blocker.
* The bundled libraries are also a clear review blocker. (You haven't even
unbundled those libraries that only require a configure flag to unbundle.)
* You also have bogus BuildRequires. In particular, GStreamer, which is NOT
used anywhere as far as I can tell.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]