[Bug 1225648] Review Request: compat-libvpx1 - Compat package with libvpx libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1225648

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

I guess that you might want to change that in libvpx first to keep differences
to minimum.

- URL is wrong:
compat-libvpx1.i686: W: invalid-url URL:
http://www.webmproject.org/tools/vp8-sdk/ HTTP Error 404: Not Found

- formatting:
compat-libvpx1.src:120: W: macro-in-comment %doc
compat-libvpx1.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
line 5)

Rest of rpmlint output (nothing interesting):
compat-libvpx1.i686: W: no-documentation
compat-libvpx1.i686: E: non-standard-executable-perm /usr/lib/libvpx.so.1.3.0
0775L
srpm/compat-libvpx1.spec:61: W: configure-without-libdir-spec
srpm/compat-libvpx1.spec:63: W: configure-without-libdir-spec

Please fix those minor issues at your convenience. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]