https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |psabata@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> --- Bill, Athos, there are actually some issues with this package. * The perl version constraint (buildtime dependency) has no practical efect. * The package calls `find', `make', `rm' and `rmdir', yet doesn't depend on packages providing these commands. Note Fedora Packaging Guidelines no longer list any packages guaranteed to be present in every buildroot. Add `coreutils', `findutils' and `make' as build dependencies. * The minimum required version of ExtUtils::MakeMaker is 6.30. (Makefile.PL:8) * Some perl build dependencies are missing: - strict, used in Makefile.PL, tests and the tested code - Test, used in tests - warnings, used in Makefile.PL and the tested code * The Exporter runtime dependency is autodetected and doesn't need to be explicitly Require'd. * Modern EU::MM supports DESTDIR. This can be used in place of PERL_INSTALL_ROOT. * Line 34 is unnecessary. (find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;) * The `dist.ini' file has zero value for the end user and I would advise against packaging it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review