https://bugzilla.redhat.com/show_bug.cgi?id=1243499 --- Comment #2 from José Matos <jamatos@xxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > I was worried about issues with backwards compatiblity. But this package > does not override the module in Python 2.7 stdlib because the name is > different (configparser vs. ConfigParser). I think a note about this should > be added to %description, to avoid confusion. OK. I will add a note. > You make the package only for Python 2.7, so any mention of other versions > should be removed from %description. I disagree. The idea of the sentence is that the code can be used unchanged from versions 2.6 to 3.5 (btw excluding 3.0 and 3.1). This is relevant. What I agree that it can be done is to improve the last remark and say something like this this: "This package is not available for python 3 since it belongs to standard library starting from python 3.2 so it is already installed with python 3." I welcome improvements to the sentence above. :-) > There is no license file. > Also, I think licensing might be wrong. CPython is licensed under PYTHON > SOFTWARE FOUNDATION LICENSE VERSION 2, and configparser is directly derived > from that, so should also be licensed the same. I think that licensing it as > MIT might be a mistake, unless configparser is indpendently derived from a > different source. Upstream maintainer of configparser in cpython prepared > the stand-alone configparser module, so it's possible that he is simply has > copyright to the code and decided to provide it under a different license. > Either way, please confirm the license, and ask upstream to include a > license file. I took the time to confirm the license. In a sense for me that is the most important check that needs to be done while packaging. :-) The source for the license is the pypi package whose the index responsibility is from author of the code (the same that is in python standard library). The license there is MIT. FWIW both debian and Arch maintainer agree with this assessment: http://metadata.ftp-master.debian.org/changelogs//main/c/configparser/configparser_3.3.0r2-2_copyright https://aur.archlinux.org/packages/python2-configparser/ In any case agree that, according to "The Zen of Python", "Explicit is better than implicit." So I will ask the author to add a license file to the code. > No issues with packaging otherwise. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review