https://bugzilla.redhat.com/show_bug.cgi?id=1242056 --- Comment #5 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi Paulo, Thank you for your Review! > But before sponsoring you, I would like to see at > least one informal package review from you. Here is my first review attempt: https://bugzilla.redhat.com/show_bug.cgi?id=1243507 I also replied in this request where sources were not available, I was not sure what to do with the ticket status though: https://bugzilla.redhat.com/show_bug.cgi?id=1229913 > Please fix: > [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf %{buildroot} present but not required > The line > find %{buildroot}%{gem_instdir}/bin -type f | xargs chmod a+x > does not appear to be required as well, for this specific package. Done and bumped the release. (shoud I bump it even if it wasn't uploaded to fedora cgit? i.e. during the review process?) New files are at: Spec URL: https://ribeiro.fedorapeople.org/rubygem-chake.spec SRPM URL: https://ribeiro.fedorapeople.org/rubygem-chake-0.7-2.fc22.src.rpm > Please comment: > [?]: Development files must be in a -devel package > Can you guarantee all files installed are required for runtime? Or > some are only need for development? Yes. We could question the chake.spec.erb file (which is a template to generate a spec file) presence in there, but it is called by the Rakefile which is installed by the -doc package, which means that if we move that to a devel package the -doc package would require the -devel one. It is in the gem in order to generate rpm packages from it. For the next version I will submit a patch to change this rpm generation (I am already having this conversation with upstream). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review