https://bugzilla.redhat.com/show_bug.cgi?id=1193878 Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #14 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal@xxxxxxx> --- Okay. Just one minor nitpick: $ rpmlint qmasterpassword-1.1-2.fc21.src.rpm qmasterpassword.src:73: W: macro-in-%changelog %check 1 packages and 0 specfiles checked; 0 errors, 1 warnings. In the %changelog or in other comments anywhere in the spec file, some macros expand and cause side-effects, which may even influence the build in bad ways. Imagine you added a changelog comment mentioning the "%configure" macro. In the built packages you would get to see the exanded macro, i.e. a big blog as can be seen in "rpm -E %configure". Hence in comments it is better to escape macros with a double '%%'. > -BuildRequires: qt5-qtbase-devel >= 5.2.0 > +BuildRequires: qt5-qtbase-devel Note that my earlier comment referred to the "Requires" tag only, not the BuildRequires. It's okay to drop the version here, too, but minimum versions on BuildRequires can be helpful actually when trying to build a src.rpm for a completely unexpected build target. For example, if Fedora EPEL 6 did not contain Qt 5.4.x already, the src.rpm would fail to build. Though, in many packages, minimum version requirements are out-of-date, and configure scripts or other version checks are applied by the used build framework. > %changelog There is nothing about this in the guidelines, https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs and it is no blocker criterion, but "rpm --query --changelog …" output adds an empty line between individual changelog entries for increase readability. So, it's widely accepted practice to do that also in the spec file and increase readability. Decide yourself whether you like that, too. * Package builds fine on Rawhide and F21. * Basic installation and runtime testing: F21 with GNOME Shell Package APPROVED. Please fix the unescaped macro in %changelog when/after importing into dist git. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review