[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241919



--- Comment #17 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
(In reply to Jackson Isaac from comment #16)
> (In reply to Matthias Runge from comment #14)
> > more comments:
> > 
> > - your package needs to provide python2-line_profiler and
> > python3-line_profiler
> 
> This can be done by adding Provides: python2-%{pkgname} and inside python3
> if block Provides: python3-%{pkgname} ?

You don't need to explicitly provide python3-%{pkgname} as that is the name of
the sub-package.

> Also, the script placed in /usr/bin would be of same name, so I would have
> to add %{_bindir}/kernprof2 and %{_bindir}/kernprof3 under %files so that
> py2/py3 versions of it can be used along each other. Should I add a '-'
> between kernprof and version too ?

Custom is to use %{_bindir}/kernprof-%{python2_version} (and python3_version).

> > - drop requires on python2, python3 and python-libs
> Aren't they required while building as such ? or rather they are shipped
> along with the installation CD ?

Automatically brought in by python2-devel/python3-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]