[Bug 1241292] Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241292

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
[!]: License field in the package spec file matches the actual license.
  => BSD (composer says BSD-2-clause, LICENSE looks like BSD-3 but we dont
care)

-License:       MIT
+License:       BSD

[~]: Rpmlint is run on all installed packages.
  => E: description-line-too-long C

proposal
-[1]
https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-7-http-message.md
+[1] http://www.php-fig.org/psr/psr-7/

PErhaps better to use full patch for symfony

-        require_once 'Symfony/Component/ClassLoader/ClassLoader.php';
+        require_once
'%{phpdir}/Symfony/Component/ClassLoader/ClassLoader.php';


License is a blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]