https://bugzilla.redhat.com/show_bug.cgi?id=1237042 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for F23 x86_64 + rpmlint on all generated rpms gave output nodejs-validate-npm-package-name.noarch: W: only-non-binary-in-usr-lib nodejs-validate-npm-package-name.noarch: W: dangling-symlink /usr/lib/node_modules/validate-npm-package-name/node_modules/builtins /usr/lib/node_modules/builtins 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha256sum) upstream tarball: de89107058e7f6268c10e4cccff6513c191d3776042569196b3362b80bbcf2f8 srpm tarball: de89107058e7f6268c10e4cccff6513c191d3776042569196b3362b80bbcf2f8 + License is "ISC" which is valid and is included in its own text file LICENSE. + rest looks as per packaging guidelines. Suggestions: 1) note generally nodejs noarch packages don't need following BuildRequires: nodejs-devel remove it. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review