Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nikto - Web server scanner https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239097 faucamp@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From faucamp@xxxxxxxxxx 2007-05-31 03:28 EST ------- (In reply to comment #10) > Is %prep the right place for this sed magic? Yes, because we are essentially just applying an "in-line" patch :-). The sed magic modifies (i.e. patches or "prepares") the package content for compilation (it is not actually being built yet) and installation (obviously it's not being installed yet either). In this case, "compilation" is not applicable, so %build is empty, but patching a file using sed is not equivalent to "building" it. Anyhow, on with the review: + Good points from comment #7 still apply, except: + rpmlint output isn't silent, but OK: W: nikto invalid-license Custom, see LICENSE.txt -- This is expected, due to the fact that the code is GPL, but the .db content isn't. (see comment #7) + Requires are good + License is good (code under GPL and content freely distributable with this program) + License field gives appropriate license information + %docs are good + program installs and runs fine Everything looks fine. ------------------------- This package is APPROVED. ------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review