[Bug 1089962] Review Request: radeontop - View GPU utilization off AMD/ATI Radeon devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089962

Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bjoern.esser@xxxxxxxxx      |bugs.micheal@xxxxxxx
              Flags|fedora-review?              |



--- Comment #11 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.micheal@xxxxxxx> ---
> Summary:    View GPU utilization off AMD/ATI Radeon devices

s/off/of/


> Group:      System Environment/Libraries

It's still not a library. ;)  

Repeating my earlier comment, you may want drop the optional Group tag or pick
a more suitable group from /usr/share/doc/rpm/GROUPS.


> %install
> make install PREFIX=%{_prefix} DESTDIR=%{buildroot}

Something's broken here. This step recompiles the entire program using
different flags as in %build.


> %doc README.md COPYING

Since early 2015, the guidelines want packagers to use the %license macro:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]