[Bug 1014544] Review Request: almohawell - Linux Packages Installer and Convertor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1014544

Dmitrij S. Kryzhevich <kryzhev@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kryzhev@xxxxxxxx



--- Comment #26 from Dmitrij S. Kryzhevich <kryzhev@xxxxxxxx> ---
1. Perl modules should go to %{perl_vendorlib}. See [1].
2. There is no %license macros, only License tag. LICENSE and gpl-2.0.txt files
are to go in %doc.
3a. LICENSE file has wrong permissions: 775. Should be 644.
3b. almohawell file has wrong permissions: 775. Should be 755.
3c. pm files have wrong permissions: 775. Should be 644.
4. Package must have proper perl requirement. See [1].
5. In header, spaces and tabs are mixed. Please choose one of them.
6. In Description please add spaces after commas: "... Rpm, Deb, Tgz ...".

[1] https://fedoraproject.org/wiki/Packaging:Perl?rd=Packaging/Perl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]