[Bug 1239273] Review Request: golang-github-BurntSushi-toml-test - Language agnostic test suite for TOML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1239273



--- Comment #6 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Better inspiration are spec files of etcd or cadvisor packages. 

> In my opinion, the fact that /usr/share/gocode/src/github.com/BurntSushi
> shouldn't cause trouble the the files for golang-github-BurntSushi-toml
> will be located in /usr/share/gocode/src/github.com/BurntSushi/toml and
> the one for golang-github-BurntSushi-toml-test in
> /usr/share/gocode/src/github.com/BurntSushi/toml-test. But requiring
> golang-github-BurntSushi-toml in golang-github-BurntSushi-toml-test can be
> a solution even if golang-github-BurntSushi-toml is not required in any way.

If toml-test binary it self calls in some way toml binary then yes,
golang-github-BurntSushi-toml must be a runtime dependency of toml-test.
Otherwise not.

The latest commit of toml-test already contains import of
github.com/BurntSushi/toml so once you update to it, add BuildRequires on it.
In any case you can run 'gofed lint' in a directory containing spec file and
tarball. It will lists you all missing/superfluous packages.

If there is somethine else that needs an explanation just let me know :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]