https://bugzilla.redhat.com/show_bug.cgi?id=1233988 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Gerald Cox from comment #1) > Approved. Thank you once again for the review. > - E: incorrect-fsf-address /usr/share/licenses/gap-pkg-crystcat/GPL > It is recommended you advise upstream. Will do. > - %check is present and all tests pass. Most GAP packages ship with test code, but this one does not. I'll see if I can cook up something on my own. > - Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated". 2 files have unknown license. > It is suggested you advise upstream. The two files with unknown license are both parts of the manual sources. One of them, doc/manual.tex, actually does say that the entire package is distributed under the GPLv2+, so I don't think there is anything to do here. > - W: only-non-binary-in-usr-lib > Looks like the same situation that occurred in rhbz#1233984 Right. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review