https://bugzilla.redhat.com/show_bug.cgi?id=1228091 --- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required No blocker... as usual, remove EPEL5 bits after initial import. The following is not required: BuildRequires: php-gd No blocker... can be removed after initial import. rpmlint: php-zetacomponents-console-tools.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/php-zetacomponents-console-tools/design/console.xml php-zetacomponents-console-tools.noarch: W: file-not-utf8 /usr/share/doc/php-zetacomponents-console-tools/design/console.xml Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1239040 bytes in 42 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation There are about 1.2M of docs which should be subpackaged. For library autoloader generated in %build, shouldn't require_once 'ezc/Base/autoloader.php'; be require_once '%{ezcdir}/Base/autoloader.php'; For the tests autoloader generated in %check, shouldn't require '$PWD/src/autoloader.php'; be require '%{buildroot}%{ezcdir}/%{gh_project}/autoloader.php'; so the tests verify what will be installed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review