https://bugzilla.redhat.com/show_bug.cgi?id=1228090 --- Comment #4 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required No blocker... as usual, remove EPEL5 bits after initial import. Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3932160 bytes in 127 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation There are almost 4M of docs which should be subpackaged. [!]: Sources contain only permissible code or content. [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files docs/tutorial/tutorial_font.fdb (?) docs/tutorial/tutorial_font.pfb docs/tutorial/tutorial_font.ttf I believe these should be removed... so probably the entire tutorial dir should be removed as well unless just the tutorial portions that use these font files can be removed. For library autoloader generated in %build, shouldn't require_once 'ezc/Base/autoloader.php'; be require_once '%{ezcdir}/Base/autoloader.php'; For the tests autoloader generated in %check, shouldn't require '$PWD/src/autoloader.php'; be require '%{buildroot}%{ezcdir}/%{gh_project}/autoloader.php'; so the tests verify what will be installed? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review