https://bugzilla.redhat.com/show_bug.cgi?id=1241383 Marcin Haba <marcin.haba@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marcin.haba@xxxxxxxxx --- Comment #2 from Marcin Haba <marcin.haba@xxxxxxxxx> --- Hello, It is informal review due to I am not Fedora packages maintainer. Few comments: License: - License is in PDF format instead of text format (waqf2-ar.pdf) - License WAQFv2 is provided in an Arabic language. - I have no idea about this license WAQF2. Could you tell if this license is pointed on following link: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses - In LICENSE file is text "Licened under WAQFv2 or GPLv3". When your script is provided on WAQFv2 and when on GPLv3? - In file LICENSE in text "Licened under WAQFv2 or GPLv3" the word "Licened" should be "Licensed". - SRPM: - You attached link to RPM, not SRPM. Script: - Yum command has been deprecated. You can try to use dnf. - mkchroot requires root account, so the script should be placed in /usr/sbin, not /usr/bin - script does not provide any interface (at least like: usage:, --help, --version ...etc.). - script requres to run (or look inside script) for know how it works and what it do. - this command: "yum -y --nogpg ..." can be dangerous because it skips checking GPG signatures. - in case validation error always is returned exitcode 0 instead of exitcode > 0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review