https://bugzilla.redhat.com/show_bug.cgi?id=1240116 Javier Peña <jpena@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpena@xxxxxxxxxx --- Comment #4 from Javier Peña <jpena@xxxxxxxxxx> --- Please be aware that this is an informal review. I have some comments about the spec file: - I think it might be better to fetch the source code directly from GitHub or PyPi. I have been doing some tests using https://pypi.python.org/packages/source/m/%{pypi_name}/%{pypi_name}-%{version}.tar.gz and it works fine for me (with some details, see below). - At least on the PyPi source, license is included in a license.txt file together with the sources, so you can use "%license %{python2_sitelib}/music21/license.txt" with it. - I see the sources include some external libraries in music.ext, and your spec file patches them manually using sed to avoid library bundling. Is there any open request upstream to avoid this? - rpmlint complains twice about macro-in-comment, and mixed spaces and tabs in line 29. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review