https://bugzilla.redhat.com/show_bug.cgi?id=1241812 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Haïkel Guémar <karlthered@xxxxxxxxx> --- Few things: * a typo in download url https://pypi.python.org/packages/source/k/keystoneauth/keystoneauth-0.2.0.tar.gz * naming guidelines require that python libraries package name to be prefixed by "python-" * no upper bounds on requirements => python-requests < 2.4.0 is responsible of failing the package installation as we have newer one. In this case, it's not a problem having a newer requests. * lower bounds are rarely updated so I advise to use them when necessary (python-six and python-requests requires them for instance) * Group: Documentation could be dropped, it's not used anymore (even on EL7) * I recommend using %license LICENSE to declare license files in %files * wrap description text in 80 columns * rdopkg reqquery -r test-requirements.txt shows that all dependencies for running tests are present, could you run them in %check As a prerequisite for the sponsorship process, could you do two informal reviews among those ones? https://bugzilla.redhat.com/show_bug.cgi?id=1241808 https://bugzilla.redhat.com/show_bug.cgi?id=1233168 https://bugzilla.redhat.com/show_bug.cgi?id=1241088 I plan to review all liberty deps after F23 is branched (next week). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review