[Bug 1241282] Review Request: rpm-mpi-hooks - RPM dependency generator hooks for MPI packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241282

Orion Poplawski <orion@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orion@xxxxxxxxxxxxx



--- Comment #8 from Orion Poplawski <orion@xxxxxxxxxxxxx> ---
>From -devel list:

>
> libfoo.so()(64bit)
> libfoo.so()(64bit)(openmpi-x86_64)
>

Isn't the -x86_64 redundant?  Also though I guess we don't have an mpi
variable MPI_NAME.

Also, your trick of using:

  for module in $(module avail 2>&1 | grep "^mpi/"); do

to find the available mpi modules needs a "-t" option for Lmod.  Fortunately
this also works with environment-modules:

 for module in $(module -t avail 2>&1 | grep "^mpi/"); do

Also, it doesn't seem to get all of the requires quite right.  For
scorep-openmpi I have:

Provides: libscorep_adapter_compiler_event.so.2()(64bit)(openmpi-x86_64)

but:

Requires: libscorep_adapter_compiler_event.so.2()(64bit)

is being emitted.  This appears to be coming from:

./fileattrs/libsymlink.attr:%__libsymlink_requires
%{_rpmconfigdir}/elfdeps --provides --soname-only

So it looks like we need to contend with that as well.

# cat fileattrs/libsymlink.attr
# Make libfoo.so symlinks require the soname-provide of the target library
%__libsymlink_requires          %{_rpmconfigdir}/elfdeps --provides
--soname-only
%__libsymlink_magic             ^symbolic link to `.*lib.*\.so\..*'$
%__libsymlink_exclude_path      ^.*[[:digit:]]$


Perhaps with:

%global __libsymlink_exclude_path     ^%{_prefix}/lib(64)?/(openmpi|mpich)/.*$

in mpi packages.  Perhaps we need a %mpi_filters or similar macro that mpi
packages need to add to their specfiles.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]