[Bug 1239148] Review Request: thefuck - App that corrects your previous console command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1239148



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
If the upstream is making new releases, then OK.

Please update to the latest version.

Add %license LICENSE.md to %files.

[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.4/site-packages/thefuck,
     /usr/lib/python3.4/site-packages/tests/rules, /usr/lib/python3.4/site-
     packages/thefuck-1.46-py3.4.egg-info
(Basically you can remove "/*" from those lines in %files.)

You cannot install files into %{python3_sitelib}/tests. This is an upstream
bug, but it must be fixed in some way. Either %exclude this directory from the
package, or move the directory underneath %{python3_sitelib}/thefuck/.

Rpmlint
-------
thefuck.noarch: E: non-executable-script
/usr/lib/python3.4/site-packages/thefuck/rules/cd_correction.py 0644L
/usr/bin/env

This contains '/usr/bin/env python' which is misleading, even if not actually
used. Probably best to do 'sed -i 1d ...'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]