Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: gnome-vfs2-obexftp: ObexFTP filesystem support for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231005 ------- Additional Comments From bnocera@xxxxxxxxxx 2007-05-30 18:49 EST ------- (In reply to comment #12) <snip> > license: there is a clarification of the current status in README.license, > which is good; we should really get upstream to clarify this though. I'm not sure what more can be done. Each piece of code making up the package is under a specific licence, or dual-licenced. Linking (at build-time or run-time) against the other libraries restrict that dual-licencing. I believe that stating that each piece of code retain their licence, and that the whole package, as a binary, when run, is of GPL licence should be enough. > suggestions: > - use %{?dist} Done. > - require perl(XML::Parser), which is the more perl-correct version of > that requires Done (although a number of other packages just require perl-XML-Parser...) > - Would be nice if the %description mentioned Bluetooth. Done. > - Might also be nice if the description did _not_ mention Midnight > Commander... Yeah, this is broken. Done. > - The capitalization of ObexFTP should be consistent between summary > and description Done. (In reply to comment #13) > rpmlint (upstream development version): > gnome-vfs2-obexftp.x86_64: W: conffile-without-noreplace-flag > /etc/gnome-vfs-2.0/modules/obex-module.conf > Any particular reason for not making that noreplace? It's not really a config file, it's a file that advertises a particular plugin as supporting a specific gnome-vfs scheme. Nobody ever changes this. > About %description: is this really split from the main gnome-vfs package? Looks > like a separate package, ditto upstream. It's not, fixed. (In reply to comment #14) > my mock build failed with > > configure.ac:20: warning: macro `AM_DISABLE_STATIC' not found in library > configure.ac:21: warning: macro `AM_PROG_LIBTOOL' not found in library > configure.ac:13: error: possibly undefined macro: AC_PROG_LIBTOOL > If this token and others are legitimate, please use m4_pattern_allow. > See the Autoconf documentation. > autoreconf: /usr/bin/autoconf failed with exit status: 1 > > I guess we are missing some > > BuildRequires: libtool, automake automake was already there. I added libtool, hope this is enough to fix the problem. * Wed May 30 2007 - Bastien Nocera <bnocera@xxxxxxxxxx> - 0.2-6 - Fix description, this package isn't split from gnome-vfs2 - Add the dist to the release - Use the "perl correct" build requires for intltool's dependencies - Add missing BRs for the autoreconf - Add TODO file http://people.redhat.com/bnocera/gnome-vfs2-obexftp/gnome-vfs2-obexftp-0.2-6.src.rpm http://people.redhat.com/bnocera/gnome-vfs2-obexftp/gnome-vfs2-obexftp.spec -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review