https://bugzilla.redhat.com/show_bug.cgi?id=1228172 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, (In reply to gil cattaneo from comment #6) > Spec URL: https://gil.fedorapeople.org/jedis.spec > SRPM URL: https://gil.fedorapeople.org/jedis-2.7.2-2.fc22.src.rpm Thanks, sorry for being a bit slow to respond. Full review done: Good: - rpmlint checks return: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Everything looks good: Approved. Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review