[Bug 1241412] Review Request: python-ldap3 - Strictly RFC 4511 conforming LDAP V3 pure Python client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1241412



--- Comment #2 from Matej Stuchlik <mstuchli@xxxxxxxxxx> ---
* You are mixing the use of spaces and tabs. For instance version is indented
with spaces, whereas release is indented with tabs. To avoid this in future, I
advise putting the following into your .vimrc:

:set tabstop=4
:set shiftwidth=4
:set expandtab

* Since the package does not contain any architecture specific files, it should
be marked noarch

* The utils directory contains backport of ssl.match_hostname,
ssl._dnsname_match_backport and CertificateError. You'll want to remove these,
patch the code so that it uses the backports-ssl_match_hostname package
instead, when necessary, and try to get the patch accepted upstream. Good luck!
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]