https://bugzilla.redhat.com/show_bug.cgi?id=1241282 --- Comment #1 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: You should probably add a header to the individual source files indicating that they are in the public domain (assuming that's your intention-I am assuming the because of the license tag in the spec file). Note that the default Fedora contributor license is MIT for code - are you sure you wish to place these files in the public domain? See other items below ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. You should probably add a header to the individual source files indicating that they are in the public domain. Note that the default Fedora contributor license is MIT for code - are you sure you wish to place these files in the public domain? [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/rpm/fileattrs This directory is owned by rpm-build and so your package should Require rpm-build. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. See above for rpm-build [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). See above [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rpm-mpi-hooks-1.0-1.fc22.noarch.rpm rpm-mpi-hooks-1.0-1.fc22.src.rpm rpm-mpi-hooks.noarch: W: spelling-error %description -l en_US openmpi -> opening rpm-mpi-hooks.noarch: W: spelling-error %description -l en_US mpich -> chimp rpm-mpi-hooks.noarch: W: spelling-error %description -l en_US devel -> delve, delve, devil, revel rpm-mpi-hooks.noarch: E: changelog-time-in-future 2015-07-09 rpm-mpi-hooks.noarch: W: no-url-tag rpm-mpi-hooks.noarch: W: only-non-binary-in-usr-lib rpm-mpi-hooks.noarch: W: no-documentation rpm-mpi-hooks.src: W: spelling-error %description -l en_US openmpi -> opening rpm-mpi-hooks.src: W: spelling-error %description -l en_US mpich -> chimp rpm-mpi-hooks.src: W: spelling-error %description -l en_US devel -> delve, devil, revel rpm-mpi-hooks.src: E: changelog-time-in-future 2015-07-09 rpm-mpi-hooks.src: W: no-url-tag rpm-mpi-hooks.src: W: strange-permission mpi.prov 0755L rpm-mpi-hooks.src: W: strange-permission mpi.req 0755L 2 packages and 0 specfiles checked; 2 errors, 12 warnings. --> By the time you read this the changelog entry won't be in the future :) Rpmlint (installed packages) ---------------------------- rpm-mpi-hooks.noarch: W: spelling-error %description -l en_US openmpi -> opening rpm-mpi-hooks.noarch: W: spelling-error %description -l en_US mpich -> chimp rpm-mpi-hooks.noarch: W: spelling-error %description -l en_US devel -> delve, devil, revel rpm-mpi-hooks.noarch: E: changelog-time-in-future 2015-07-09 rpm-mpi-hooks.noarch: W: no-url-tag rpm-mpi-hooks.noarch: W: only-non-binary-in-usr-lib rpm-mpi-hooks.noarch: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 6 warnings. Requires -------- rpm-mpi-hooks (rpmlib, GLIBC filtered): /bin/bash filesystem rpm Provides -------- rpm-mpi-hooks: rpm-mpi-hooks Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1241282 Buildroot used: fedora-22-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review