https://bugzilla.redhat.com/show_bug.cgi?id=1240634 --- Comment #1 from Robert Kuska <rkuska@xxxxxxxxxx> --- 1. It is not needed to define __python2 and python2_sitearch macros at the top of your specfile, they are already defined and ready to use 2. You miss a LICENSE file, this file is missing also in upstream, you should add LICENSE file as a new Source also consider reporting this to upstream, from packaging guidelines[0]: "If the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license. If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake." 3. You don't list %doc files - README.rst changelog and trophy-case.rst 4. There is a macro in comment "# %check section was not included, because properly working test" you should escape your macro or remove it from comment 5. Your summaries are too long, make them shorter :-) 6. Description line at python3 subpackage is also too long 7. Use %{_bindir} macro at %files section 8. Changelog is in a wrong format, correct format is: * Tue Jul 07 2015 Michal Cyprian <mcyprian@xxxxxxxxxx> - 0.2-1 9. .so files shipped by your rpms seems to have wrong file permissions 775, you can use rpm files directive to solve this - %defattr(755, root, root, -)[1] [0]https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines [1]http://www.rpm.org/max-rpm-snapshot/s1-rpm-specref-files-list-directives.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review