[Bug 1077030] Review Request: python-semantic-version - library implementing SemVer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1077030



--- Comment #13 from Michael Hrivnak <mhrivnak@xxxxxxxxxx> ---
Thanks for the help. I have made the changes locally, but have two questions,
both related to el6.

I agree that moving the _licencedir stuff to the top makes sense, but when I do
so, the el6 build reports this error:

----------------
Processing files: python-semantic-version-2.4.2-1.el6.noarch
error: File must begin with "/": BSD
error: File must begin with "/": LICENSE
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.B95reb
+ umask 022
+ cd /root/rpmbuild/BUILD
+ cd python-semanticversion-2.4.2
+
DOCDIR=/root/rpmbuild/BUILDROOT/python-semantic-version-2.4.2-1.el6.x86_64/usr/share/doc/python-semantic-version-2.4.2
+ export DOCDIR
+ rm -rf
/root/rpmbuild/BUILDROOT/python-semantic-version-2.4.2-1.el6.x86_64/usr/share/doc/python-semantic-version-2.4.2
+ /bin/mkdir -p
/root/rpmbuild/BUILDROOT/python-semantic-version-2.4.2-1.el6.x86_64/usr/share/doc/python-semantic-version-2.4.2
+ cp -pr ChangeLog README.rst
/root/rpmbuild/BUILDROOT/python-semantic-version-2.4.2-1.el6.x86_64/usr/share/doc/python-semantic-version-2.4.2
+ exit 0


RPM build errors:
    File must begin with "/": BSD
    File must begin with "/": LICENSE
----------------

If I move the same line back to right above the use of "%license", the error
goes away. Any ideas?

Question 2: After making the requested changes, I get the following errors on
el6 from rpmlint. I believe this is why I had the "%defattr" use "Buildroot"
usage. Since I plan to get this into epel6 also, can/should I keep those
statements in the spec file? Or is there some other solution that's better?


----------
python-semantic-version.spec:129: E: files-attr-not-set
python-semantic-version.spec:130: E: files-attr-not-set
python-semantic-version.spec:131: E: files-attr-not-set
python-semantic-version.spec:132: E: files-attr-not-set
python-semantic-version.spec:136: E: files-attr-not-set
python-semantic-version.spec:137: E: files-attr-not-set
python-semantic-version.spec:138: E: files-attr-not-set
python-semantic-version.spec:142: E: files-attr-not-set
python-semantic-version.spec:143: E: files-attr-not-set
python-semantic-version.spec: W: no-cleaning-of-buildroot %install
python-semantic-version.spec: W: no-cleaning-of-buildroot %clean
python-semantic-version.spec: W: no-buildroot-tag
python-semantic-version.spec: W: no-%clean-section
----------

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]