[Bug 1239160] Review Request: python-flask-cache - Adds cache support to your Flask application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1239160

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) ah sorry I was only meant to say to use python2-devel instead of
python-devel. There are very less python2-<module> packages available in the
repository so all BR: and Requires: should use python-<module> only for now.

2) rpmlint now gives output as
python3-flask-cache-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python3-flask-cache-doc/html/_static/jquery.js
python3-flask-cache-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/python3-flask-cache-doc/html/.buildinfo
python-flask-cache.src:28: W: unversioned-explicit-provides python2-flask-cache
python-flask-cache-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-flask-cache-doc/html/_static/jquery.js
python-flask-cache-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-flask-cache-doc/html/objects.inv
python-flask-cache-doc.noarch: W: file-not-utf8
/usr/share/doc/python-flask-cache-doc/html/objects.inv
python-flask-cache-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/python-flask-cache-doc/html/.buildinfo
5 packages and 0 specfiles checked; 0 errors, 7 warnings.
=> From above you can remove .buildinfo file in %build section so it will not
be packaged. Then others also you can fix by looking into
https://fedoraproject.org/wiki/Common_Rpmlint_issues

or here is ready solution 
rm -f build/html/.buildinfo
sed -i 's/\r$//' build/html/_static/jquery.js
iconv -f iso8859-1 -t utf-8 build/html/objects.inv > objects.inv.conv
mv -f objects.inv.conv build/html/objects.inv


3) Only if you want to build this package on EPEL you need that preamble of
defining with_python3 or python2 macro, otherwise not needed for fedora
packaging.

rest looks fine.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]