https://bugzilla.redhat.com/show_bug.cgi?id=1060920 --- Comment #21 from Scott K Logan <logans@xxxxxxxxxxx> --- Thanks for digging into this, Rich. I know it is a pretty big package. This was among the first *real* SPEC files that I wrote, so looking back now, I see a bunch of rookie mistakes. I did my best to "spiffy" it up - I'm sure we'll spot more issues, however. I should mention that I intend to target EPEL7. Key changes: - Update to packaging guidelines regarding %license - Performed downstream .so versioning (See [1]) for libOpenNI2.so. I gathered from the changelog that API changes could happen with minor version changes, so that is the SONAME version I used. If my understanding is correct, we DON'T need to .so version the libraries in /usr/lib64/openni2/ because they aren't ever linked against...correct? - Removed Requires: jpackage-utils - Added %{?_isa} to subpackage Requires where appropriate - %install phase now preserves timestamps - Use CFLAGS during build - Fixes for GCC 5 and special CFLAGS used by Fedora [1] https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Downstream_.so_name_versioning Spec URL: http://cottsay.fedorapeople.org/openni2/openni2.spec SRPM URL: http://cottsay.fedorapeople.org/openni2/openni2-2.2.0.33-2.fc23.src.rpm Koji scratch builds: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10291443 rpmlint output: openni2.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight openni2.src: W: spelling-error %description -l en_US lifecycle -> life cycle, life-cycle, Wycliffe openni2-doc.noarch: W: no-documentation openni2-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados openni2.x86_64: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight openni2.x86_64: W: spelling-error %description -l en_US lifecycle -> life cycle, life-cycle, Wycliffe openni2.x86_64: W: no-manual-page-for-binary Ni2Viewer openni2.x86_64: W: no-manual-page-for-binary PSLinkConsole openni2.x86_64: W: no-manual-page-for-binary PS1080Console openni2-devel.x86_64: W: only-non-binary-in-usr-lib openni2-devel.x86_64: W: no-documentation openni2-examples.x86_64: W: no-documentation openni2-examples.x86_64: W: no-manual-page-for-binary MWClosestPointApp openni2-examples.x86_64: W: no-manual-page-for-binary SimpleViewer openni2-examples.x86_64: W: no-manual-page-for-binary MultiDepthViewer openni2-examples.x86_64: W: no-manual-page-for-binary ClosestPointViewer openni2-examples.x86_64: W: no-manual-page-for-binary MultipleStreamRead openni2-examples.x86_64: W: no-manual-page-for-binary EventBasedRead openni2-examples.x86_64: W: no-manual-page-for-binary SimpleRead openni2-java.x86_64: W: no-documentation 8 packages and 1 specfiles checked; 0 errors, 20 warnings. Thanks, --scott -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review