https://bugzilla.redhat.com/show_bug.cgi?id=1239160 --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + Package built successfully in mock F23 (x86_64) + rpmlint on all generated rpms gave output 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) source in srpm:90126ca9bc063854ef8ee276e95d38b2b4ec8e45fd77d5751d37971ee27c7ef4 source upstream:90126ca9bc063854ef8ee276e95d38b2b4ec8e45fd77d5751d37971ee27c7ef4 + License "BSD" is valid and included in its own text file LICENSE. + Follows python packaging guidelines Suggestions: 1) Python Guidelines now recommend versioned python usage so wherever used python, use python2 e.g. use BuildRequires: python2-devel 2) Python guidelines now changed, use in %prep as %if 0%{?with_python3} cp -a python2 python3 find python3 -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' %endif # with_python3 find python2 -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|' 3) Similarly use python2 and python3 directory names as given for other parts of spec file like %build, %install, %check from https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file 4) we don't need to install MANIFEST.in 5) You need to generate the documentation using sphinx module and not to just copy the docs directory. You now need to add 2 more subpackages (-doc and python3-flask-cache-doc) e.g. %package doc Summary: Documentation for the Flask-Cache module BuildRequires: python-sphinx %description doc Documentation for the Flask-Cache module Please reword summary and description if needed then in %build you need to build for python2 and python3. For python2 you can do as # for docs pushd docs sphinx-build -b html -d build/doctrees . build/html popd and then %files doc %doc docs/build/html %files -n python3-flask-cache-doc %doc docs/build/html I think I should wait for these changes before approving this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review