[Bug 1232433] Review Request: python-certifi - Python package for providing Mozilla's CA Bundle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1232433



--- Comment #9 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
I see you've also fixed the license field. You really should get into the habit
of recording all changes you make in the spec file changelog. This also helps
with review - most folks also post the changelog entry into the BZ review
tickets along with the updated Spec URL and SRPM URL to help the reviewer
quickly see what has been changed.

OK, so still to address:

1. Removing the shell bangs from lib files to silence rpmlint errors. Something
like the following (untested) in %install:

#drop shebangs from python_sitearch
find %{buildroot}%{python_sitelib}/%{pypi_name} -name '*.py' \
    -exec sed -i '1{\@^#!/usr/bin/env python@d}' {} \;

Obviously you'll need to adapt that and do it for both python 2 and 3.


2. Raising the license file issue with upstream - please post a link to an
upstream ticket.


Once those are adressed, this should be good to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]