https://bugzilla.redhat.com/show_bug.cgi?id=1235305 Jeff Backus <jeff.backus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeff.backus@xxxxxxxxx Flags| |fedora-review? --- Comment #7 from Jeff Backus <jeff.backus@xxxxxxxxx> --- Hi folks, I've done a formal review. Here are the highlights, with the formal review below: * BR redhat-rpm-config isn't needed, however, as there is an on-going discussion about what should go in the minimum buildroot, I won't insist this is removed. Any reason this was added? * Even though BuildRequires allows multiple listings on one line, please only provide one. Specifically, line 25... * Please add comments above %check section explaining why it is disabled by default and how to use it. Your explanation above is sufficient, just add it to the .spec file. * Missed the -p when installing hitch.conf on line 98. * Please remove the commented %setup macro in %prep. * Please remove the commented commands in %build * While you're making changes, the description has "It's" but should be "Its"... :) Overall, looks good. Please address the above and I'll approve it. Regards, Jeff Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: redhat-rpm-config See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated", "*No copyright* Public domain". 6 files have unknown license. Detailed output of licensecheck in /mnt/storage/backed_up/homes/jeff/tmp/reviews/hitch/review- hitch/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required Addressed in bug comments. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Buildroot: present but not needed Addressed in bug comments [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required Addressed in bug comments. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Verified by another reviewer [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Patches are Fedora/RHEL specific. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Need to document reasons it is not enabled by default and how to run it. [!]: Packages should try to preserve timestamps of original installed files. Missed the -p on hitch.conf. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: hitch-1.0.0-0.3.2.beta3.fc22.i686.rpm hitch-1.0.0-0.3.2.beta3.fc22.src.rpm hitch.i686: W: spelling-error %description -l en_US unencrypted -> encrypted hitch.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end hitch.i686: W: spelling-error %description -l en_US multicore -> multicolored hitch.i686: W: no-manual-page-for-binary hitch-openssl hitch.src: W: spelling-error %description -l en_US unencrypted -> encrypted hitch.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end hitch.src: W: spelling-error %description -l en_US multicore -> multicolored 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: hitch-debuginfo-1.0.0-0.3.2.beta3.fc22.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- hitch.i686: W: spelling-error %description -l en_US unencrypted -> encrypted hitch.i686: W: spelling-error %description -l en_US backend -> backed, back end, back-end hitch.i686: W: spelling-error %description -l en_US multicore -> multicolored hitch.i686: W: no-manual-page-for-binary hitch-openssl 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- hitch (rpmlib, GLIBC filtered): /bin/sh config(hitch) libc.so.6 libcrypto.so.10 libcrypto.so.10(OPENSSL_1.0.1) libcrypto.so.10(OPENSSL_1.0.1_EC) libcrypto.so.10(libcrypto.so.10) libev.so.4 libssl.so.10 libssl.so.10(libssl.so.10) openssl rtld(GNU_HASH) systemd-units Provides -------- hitch: config(hitch) hitch hitch(x86-32) Source checksums ---------------- https://github.com/varnish/hitch/archive/00b264b5537986fecfa1013cc27ad3b7b771a646/hitch-00b264b5537986fecfa1013cc27ad3b7b771a646.tar.gz : CHECKSUM(SHA256) this package : 4ce39f89d4567ab04199a1f41eedfd253165cb2baf3b797ea5def5dfac23a269 CHECKSUM(SHA256) upstream package : 4ce39f89d4567ab04199a1f41eedfd253165cb2baf3b797ea5def5dfac23a269 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -n hitch Buildroot used: fedora-22-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review