https://bugzilla.redhat.com/show_bug.cgi?id=1239067 --- Comment #4 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #3) > > I read somewhere rpmlint validates groups from /usr/share/doc/rpm/GROUPS > > So I choose : Development/Libraries > > $ grep Lib /usr/share/doc/rpm/GROUPS > Development/Libraries > System Environment/Libraries > > As you can see, "System Environment/Libraries" is in there, too. > > > > OK, so where is right use > > Group: Development/Libraries > > like in main package ? or should I remove Group on main package ? > > The Group tag can be set for each [sub-]package. Unless you want to drop it > everywhere: https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Sorry, I misunderstood at first time , I'd like keep Group , so : Name: libaudclient Group: System Environment/Libraries (...) %package -n libaudclient-devel Summary: Development files for libaudclient Group: Development/Libraries is correct ? or what remove second group tag or second group tag should be: Group: System Environment/Libraries ? > > Requires: %{name}}%{?_isa} = %{version}-%{release} > > The extra '}' in there causes the package to be not installable. > > > >> Directory ownership is okay, since package audacious-devel > >> is not needed for installing libaudclient-devel. > > > > So it is correct ? no modifications ? > > Yes, that's what "is okay" means. Reviewing is not only about pointing out > mistakes, it's also an opportunity to acknowledge things that are done right. > Owning /usr/include/audacious is acceptable according to this: > https://fedoraproject.org/wiki/Packaging: > Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your > _package_to_function > > > > %install > > -%make_install > > +make install DESTDIR=%{buildroot} > > A completely unnecessary change. Using %make_install is entirely acceptable. > See: rpm -E %make_install > > > https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_. > 25makeinstall_macro_should_not_be_used Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works. So I change it , is correct ? > [...] > > If you fix the Group tag in dist git and the accidental '}', you can get an > APPROVED here. OK thanks, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review