https://bugzilla.redhat.com/show_bug.cgi?id=1239067 --- Comment #2 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #1) > > Name: libaudclient > > Group: Development/Libraries > > The Group tag for runtime libraries has been "System Environment/Libraries" > for many years. Nowadays the Group tag is obsolete: > https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag I read somewhere rpmlint validates groups from /usr/share/doc/rpm/GROUPS So I choose : Development/Libraries > > BuildRequires: autoconf > > BuildRequires: automake > > Not needed. OK , fixed > > > %description > > audacious D-Bus remote control library > > The player is called "Audacious" with upper-case 'A' - except for the logo > and file names. OK, fixed > > %package -n libaudclient-devel > > Summary: Development files for libaudclient > > Group: Development/Libraries/C and C++ > > Red Hat and Fedora have used group "Development/Libraries" for -devel > packages for many years. OK, so where is right use Group: Development/Libraries like in main package ? or should I remove Group on main package ? > > Requires: %{name} = %{version}-%{release} > > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package OK, fixed > > %description -n libaudclient-devel > > Development files for libaudclient (to communicate with audacious) > > As above. OK, fixed > > ### corrects version mismatch > > sed '/^version/cversion=%{version}' -i audclient.pc > > If the comment explained *why* it does that, it would be a better comment. > Now there's a version mismatch in the file, because there are two different > versions and two different ways to retrieve those versions: > > $ grep ^version /usr/lib64/pkgconfig/audclient.pc > version=3.5 > $ pkg-config --variable=version audclient > 3.5 > > $ grep ^Version /usr/lib64/pkgconfig/audclient.pc > Version: 3.5-rc2 > $ pkg-config --atleast-version=3.5 audclient && echo "yes" > yes > $ pkg-config --atleast-version=3.5-rc2 audclient && echo "yes" > yes > $ pkg-config --atleast-version=3.5-rc3 audclient && echo "yes" > $ OK , I removed sed script This came in SUSE src.rpm, is not my script. I see now that SUSE Version was 3.5~rc2 , now is just 3.5 so it wasn't right at all . > > %build > > %configure > > make %{?_smp_mflags} > > Build output is non-verbose. One cannot see which compiler/linker flags are > used. You can insert > > sed -i '\,^.SILENT:,d' buildsys.mk.in > > before %configure to fix that. Audacious does that for years, too. ;-) DONE > > %files -n libaudclient-devel > > %dir %{_includedir}/audacious/ > > Directory ownership is okay, since package audacious-devel is not needed for > installing libaudclient-devel. So it is correct ? no modifications ? > [...] > > As for the runtime, last audtty in Fedora rebuilds and seems to run with > this. Cool! Thanks. SPEC: https://sergiomb.fedorapeople.org/libaudclient.spec SRPM: https://sergiomb.fedorapeople.org/libaudclient-3.5-0.2.rc2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review