[Bug 1186557] Review Request: libticalcs2 - Texas Instruments calculator communication library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1186557



--- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Ben Rosser from comment #5)
> > - To me, 'make -C docs install DESTDIR=%{buildroot}'
> >   is redundant; you could manage all documentation by using %doc macro.
> 
> This solution arose as a way to correctly split the documentation files
> between packages; attempting to specify relative paths in %doc caused the
> documentation to get included in both the main package and the *-doc
> subpackage.

That's because docs are installed with the main 'make install'.

> 
> By installing into %{_pkgdocdir} and then specifying what files to include
> using fixed paths, it worked.
> 
> There was some FPC discussion about this around the time I was packaging
> libtifiles2, I seem to recall. This updated documentation guideline was the
> result: https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
> 
> "Marking a relative path with %doc in the %files section will cause RPM to
> copy the referenced file or directory from %_builddir to the proper location
> for documentation. Files can also be placed in %_pkgdocdir, and the build
> scripts of the software being packaged may do this automatically when called
> in %install. However, mixing these methods is problematic and may result in
> duplicated or conflicting files, so use of %doc with relative paths and
> installation of files directly into %_pkgdocdir in the same source package
> is forbidden."

Indeed: "mixing these methods is problematic and forbidden"


Try this:

..
%install
make install DESTDIR=%{buildroot}
rm -f %{buildroot}%{_libdir}/libticalcs2.la
rm -rf %{buildroot}%{_docdir}/%{name}/html
%find_lang %{name}

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

%files -f %{name}.lang
%{_libdir}/libticalcs2.so.*
%doc README AUTHORS ChangeLog
%license COPYING

%files doc
%doc docs/html README AUTHORS ChangeLog
%license COPYING
..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]