https://bugzilla.redhat.com/show_bug.cgi?id=1235364 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Since this is a rename review request, I'm mostly looking at the relevant parts: + obsoletes/provides look correct + new names is OK according to python guidelines + license matches - license is not installed: please use %license for the license file [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text] Questions: Can the text about compatibility with "older interface written by J. Skinner" be removed? It was probably useful in 2001, but maybe nobody remembers the older interface now. Since the same documentation files are installed for both subpackages, I'd suggest adding %global _docdir_fmt %{name} to avoid duplication. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review