https://bugzilla.redhat.com/show_bug.cgi?id=1225231 Yajo <yajo.sk8@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yajo.sk8@xxxxxxxxx --- Comment #3 from Yajo <yajo.sk8@xxxxxxxxx> --- This is an unofficial review. At a first glance, I see the following errors: > License: GPLv3+ Reading the source and the project URL, it's only GPLv3. > %setup -q You might prefer %autosetup unless you target EPEL<7. See https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25autosetup > BuildRequires: python3 Should be python3-devel. See https://fedoraproject.org/wiki/Packaging:Python#BuildRequires > # configure macro does not work IMHO A little explanation would prevent future developers to lose time wondering why. > * Tue May 26 2015 Raphael Groner <projects.rg@xxxxxxxx> > - Please fill this, also with the version stuff. You might want to see the rpmlint errors too: Checking: light-locker-settings-1.5.0-1.fc21.x86_64.rpm light-locker-settings-1.5.0-1.fc21.src.rpm light-locker-settings.x86_64: W: spelling-error %description -l en_US screensaver -> screen saver, screen-saver, screens aver light-locker-settings.x86_64: W: no-version-in-last-changelog light-locker-settings.x86_64: E: no-binary light-locker-settings.x86_64: E: script-without-shebang /usr/share/light-locker-settings/light-locker-settings/light-locker-settings.glade light-locker-settings.x86_64: W: dangling-symlink /usr/share/light-locker-settings/locale /usr/share/locale light-locker-settings.x86_64: W: spurious-executable-perm /usr/share/doc/light-locker-settings/COPYING light-locker-settings.x86_64: W: spurious-executable-perm /usr/share/doc/light-locker-settings/INSTALL light-locker-settings.x86_64: W: no-manual-page-for-binary light-locker-settings light-locker-settings.x86_64: W: install-file-in-docs /usr/share/doc/light-locker-settings/INSTALL light-locker-settings.src: W: spelling-error %description -l en_US screensaver -> screen saver, screen-saver, screens aver light-locker-settings.src: W: no-version-in-last-changelog light-locker-settings.src:36: W: configure-without-libdir-spec 2 packages and 0 specfiles checked; 2 errors, 10 warnings. Also, you might want to create appdata files, or at least notify upstream a bug about it. See https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#AppData_files That's it for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review